Compiler integration of the Concat operation #1193
Open
+310
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 20, 2024 16:12
…eNHWC transformations are checking whether the node to be moved is a fork node, in which case the MoveOpPastFork is called. MoveOpPastFork uses deepcopies of the original node.
…the graph being a fork node
… and it now accepts different datatypes of inputs. It uses the new implementation from finn-hlslib
…ypes among inputs and sets the SIMD parameter
…types among inputs
3 tasks
|
@mdanilow @preusser: Do you have any idea why we see IPGen failing for this (the test_fpgadataflow_concat) for 2022.2 but seemingly not for 2023.2? The error message is simply "ERROR: [HLS 200-1715] Encountered problem during source synthesis" and then it stops... I did not really debug this further and for now do not rely on this (but I planned to...), however, as we are stuck on 2022.2 at least for some of our setups, it would be nice to figure this out. |
|
@iksnagreb I have no idea xd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on a PR from the finn-hlslib where the Concat operation was implemented (Xilinx/finn-hlslib#143)