[Thresholding] Generalize data layouts for node execution #1289
+22
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See fastmachinelearning/qonnx#143 for the similar generalization applied to QONNX MultiThreshold
|
Does this PR depend on fastmachinelearning/qonnx#143 ? Or is it related but independent? |
|
No, it does not depend on the QONNX PR, this mirrors the changes to the QONNX MultiThreshold node execution for the FINN custom-op Thresholding node execution. This is also still more of a workaround, we do not even have access to the layout annotations here so it is even less generalized and always guesses... Merging this should not break anything, behavior of the existing 2d and 4d layouts is the same, but as also proposed by @maltanar at the QONNX PR, we should seriously consider more robust alternatives to the data layout strings... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See fastmachinelearning/qonnx#143 for the similar generalization applied to QONNX MultiThreshold