Faster data unpacking #1291
Open
Faster data unpacking #1291
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be a good idea to review/merge this PR together with #1172 (@bwintermann). |
|
I indeed ran into the same issue and opened the PR mentioned by @fpjentzsch because of it. Did you measure how much faster this is than the previous approach? I would be quite happy if we didn't have to load some C code to get fast execution speed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faster implementation of finn.util.data_packing.packed_bytearray_to_finnpy. It utilizes bitshifts and is necessary for realtime processing on pynq.