Choose dimensions
or sizes
+ strides
for user-facing operations
#1922
Labels
quality
Improve code quality: maintainability, cleanup, code reorganization.
Right now, some operations take
dimensions
and some operations takesizes
andstrides
.For clarity, but also some implementation considerations, I think it would make sense to change to
sizes
/strides
.Some pros for moving to
sizes
/strides
are:dimensions
requires (at least at the python level) bothsizes
/strides
to be default or both not default. It would be nice for a user to take advantage of default values more easily. If a python wrapper function takes these values separately, then python needs to have hard-coded defaults in order to produced validdimensions
, which is not ideal.This came to my attention through comments of @fifield and @andrej in #1919
As this would be a change that touches many things, I'm recording outside of the PR for discussion and so it does not become a blocker to that PR.
The text was updated successfully, but these errors were encountered: