Use OnDispose and fix a debug log statement

Xlinka · Jul 20, 2024 · 5091b96 · 5091b96
1 parent da3974b
commit 5091b96
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/ProjectObsidian/Components/Devices/MIDI_CC_Value.cs b/ProjectObsidian/Components/Devices/MIDI_CC_Value.cs
@@ -41,9 +41,9 @@ protected override void OnStart()
         }
     }
 
-    protected override void OnPrepareDestroy()
+    protected override void OnDispose()
     {
-        base.OnPrepareDestroy();
+        base.OnDispose();
         if (_device != null)
         {
             _device.Control -= OnControl;

diff --git a/ProjectObsidian/Components/Devices/MIDI_InputDevice.cs b/ProjectObsidian/Components/Devices/MIDI_InputDevice.cs
@@ -85,9 +85,9 @@ private async void ReleaseDeviceAsync()
         _inputDevice = null;
     }
 
-    protected override void OnPrepareDestroy()
+    protected override void OnDispose()
     {
-        base.OnPrepareDestroy();
+        base.OnDispose();
         if (_inputDevice != null)
         {
             ReleaseDeviceAsync();
@@ -197,7 +197,7 @@ private void OnMessageReceived(object sender, MidiReceivedEventArgs args)
         var events = MidiEvent.Convert(args.Data, args.Start, args.Length);
         foreach (var e in events)
         {
-            UniLog.Log(e.ToString());
+            if (DEBUG) UniLog.Log(e.ToString());
             RunSynchronously(() =>
             {
                 _lastEvent.Value = e.ToString();

diff --git a/ProjectObsidian/Components/Devices/MIDI_PitchWheel_Value.cs b/ProjectObsidian/Components/Devices/MIDI_PitchWheel_Value.cs
@@ -36,9 +36,9 @@ protected override void OnStart()
         }
     }
 
-    protected override void OnPrepareDestroy()
+    protected override void OnDispose()
     {
-        base.OnPrepareDestroy();
+        base.OnDispose();
         if (_device != null)
         {
             _device.PitchWheel -= OnPitchWheel;