minor speed optimization

YahooArchive · Mar 30, 2015 · 697b50c · 697b50c
1 parent a13e0c3
commit 697b50c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/xss-filters.js b/src/xss-filters.js
@@ -19,7 +19,7 @@ exports._getPrivFilters = function () {
         NULL   = /\x00/g,
         SPECIAL_ATTR_VALUE_UNQUOTED_CHARS = /(?:^(?:["'`]|\x00+$|$)|[\x09-\x0D >])/g,
         SPECIAL_HTML_CHARS = /[&<>"'`]/g, 
-        SPECIAL_COMMENT_CHARS = /(?:^-*!?>|--!?>|--?!?$|\]>|\]$)/g;
+        SPECIAL_COMMENT_CHARS = /(?:\x00|^-*!?>|--!?>|--?!?$|\]>|\]$)/g;
 
     // Given a full URI, need to support "[" ( IPv6address ) "]" in URI as per RFC3986
     // Reference: https://tools.ietf.org/html/rfc3986
@@ -105,9 +105,9 @@ exports._getPrivFilters = function () {
             return typeof s === STR_UD ? STR_UD
                  : s === null          ? STR_NL
                  : s.toString()
-                    .replace(NULL, '\uFFFD')
                     .replace(SPECIAL_COMMENT_CHARS, function(m){
-                        return m === '--!' || m === '--' || m === '-' || m === ']' ? m + ' '
+                        return m === '\x00' ? '\uFFFD'
+                            : m === '--!' || m === '--' || m === '-' || m === ']' ? m + ' '
                             :/*
                             :  m === ']>'   ? '] >'
                             :  m === '-->'  ? '-- >'