Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some conditions to skip hits logging #817

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Add some conditions to skip hits logging #817

merged 2 commits into from
Feb 3, 2025
+66 −14

Conversation

fragosoluana
Copy link
Member

  • We shouldn't log hits when warming as it can add duplicates to the logs
  • Added a check to skip logging when hitsToLog is 0

@fragosoluana fragosoluana changed the title Add some conditions to skip logging Add some conditions to skip hits logging Feb 1, 2025
@fragosoluana fragosoluana merged commit f12984b into main Feb 3, 2025
1 check passed
@fragosoluana fragosoluana deleted the luanafragoso_skip_warming_hits_logger branch February 3, 2025 21:45
@fragosoluana fragosoluana mentioned this pull request Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprudhomme aprudhomme aprudhomme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fragosoluana @aprudhomme