Skip to content

Commit

Permalink
Add docker registry url
Browse files Browse the repository at this point in the history
  • Loading branch information
chi-yelp committed Jan 9, 2025
1 parent 013fcc5 commit 29913ef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion paasta_tools/tron_tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ def build_spark_config(self) -> Dict[str, str]:
paasta_pool=self.get_spark_executor_pool(),
paasta_service=self.get_service(),
paasta_instance=self.get_instance(),
docker_img="$PAASTA_DOCKER_IMAGE",
docker_img=f"{self.get_docker_registry()}/$PAASTA_DOCKER_IMAGE",
extra_volumes=self.get_volumes(
system_paasta_config.get_volumes(),
uses_bulkdata_default=system_paasta_config.get_uses_bulkdata_default(),
Expand Down
2 changes: 1 addition & 1 deletion tests/test_tron_tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -1322,7 +1322,7 @@ def test_format_tron_action_dict_spark(
"--conf spark.executorEnv.PAASTA_INSTANCE_TYPE=spark "
"--conf spark.executorEnv.SPARK_EXECUTOR_DIRS=/tmp "
"--conf spark.kubernetes.pyspark.pythonVersion=3 "
"--conf spark.kubernetes.container.image=$PAASTA_DOCKER_IMAGE "
"--conf spark.kubernetes.container.image=docker-registry.com:400/$PAASTA_DOCKER_IMAGE "
"--conf spark.kubernetes.namespace=paasta-spark "
"--conf spark.kubernetes.executor.label.yelp.com/paasta_service=my_service "
"--conf spark.kubernetes.executor.label.yelp.com/paasta_instance=my_job.do_something "
Expand Down

0 comments on commit 29913ef

Please sign in to comment.