Improvements to PaaSTA Playground #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cuza
commented
Oct 23, 2023
•
cuza
commented
- added paasta-cronjobs make target
- setup-kubernetes-job
- cleanup-kubernetes-job
- paasta-secrets-sync
- generate_deployments_for_service
- added VSCode debugpy as dev requirement
- made paasta playground not overrwrite existing paasta confs or yelpsoa-configs
nemacysts
approved these changes
Oct 23, 2023
| .PHONY: paasta-crons | ||
| make paasta-cronjobs: | ||
| @echo "$$ANNOUNCE_CRONS_BODY" | ||
| while true; do make paasta-secrets-sync && make cleanup-kubernetes-jobs; sleep 5; done |
There was a problem hiding this comment.
hmm, should we be a little nicer to our devboxes and run these every minute?
and just to verify that my eyes are reading this correctly: we're running this in the foreground so upon ^C we'll stop this loop?
There was a problem hiding this comment.
This is running every 5s but also is kinda lightweight since is running just using the PaaSTA playground stuff, unless you made your playground super heavy with lots of test svcs it should be fine. I also tried to avoid wait as much as possible, I don't want to wait 1m to see what happened with my yelpsoa-config change when I'm doing some rapid testing
Co-authored-by: Luis Pérez <[email protected]>
nemacysts
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.