Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct registry_uri to check if we need to sudo #3730

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jfongatyelp
Copy link
Contributor

In #3728 we changed the --docker_registry's default value from our DEFAULT_SPARK_DOCKER_REGISTRY and instead leave it undefined by default.

However, we still used args.docker_registry in our check whehter we needed sudo to push ot this registry, rather than using the generated registry_uri, which caused all runs with --build to try to sudo to push the registry, which doesn't work w/ the default registry.

This fixes to use our new registry_uri which should be either the requested docker_registry or the service's default, to get back to the normal behavior.

@nemacysts
Copy link
Member

i am dumb, sorry ;_;

@jfongatyelp jfongatyelp merged commit f4d0fcf into master Oct 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants