Use the correct registry_uri to check if we need to sudo #3730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3728 we changed the
--docker_registry
's default value from ourDEFAULT_SPARK_DOCKER_REGISTRY
and instead leave it undefined by default.However, we still used
args.docker_registry
in our check whehter we needed sudo to push ot this registry, rather than using the generatedregistry_uri
, which caused all runs with--build
to try to sudo to push the registry, which doesn't work w/ the default registry.This fixes to use our new registry_uri which should be either the requested docker_registry or the service's default, to get back to the normal behavior.