Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Delete CaC resource stuff #178

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Delete CaC resource stuff #178

wants to merge 3 commits into from

Conversation

jwartofsky-yext
Copy link
Collaborator

Deletes CaC resources from platform config, config.yaml, and the location template

@jwartofsky-yext
feat: delete visual editor resources from platform config
1448156 
Deletes all instances of visualConfiguration and theme from
the platform config and config.yaml
@jwartofsky-yext
remove configurations from location template
f514a33
@mkilpatrick
Copy link
Collaborator

We can remove all CaC, including the sample entities.

mkilpatrick
mkilpatrick approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@mkilpatrick mkilpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but don't merge. As soon as we do that new VEs won't work because of the config.yaml change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilpatrick mkilpatrick mkilpatrick approved these changes

@benlife5 benlife5 Awaiting requested review from benlife5

@asanehisa asanehisa Awaiting requested review from asanehisa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwartofsky-yext @mkilpatrick