-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accurate argument and return types on all functions (issue #512) #513
base: master
Are you sure you want to change the base?
Conversation
ffd1c9d
to
c993cef
Compare
start using deepkeys and deepindex, etc
up/down/left/right types; some rough monkey types
… this side. i think this thing might be good to go.
I think this is ready for review. There's some gaps but most of it is covered. I couldn't figure out a better way to get the exports right than making an index.js and index.d.ts, but there likely is a better way. There's some gaps still with monkey business and event listeners. Also not sure about immutability – does anything happen if the function passed to apply() mutates data? Or if you mutate the result of .get() ? |
Done making changes for the time being lmk what you think |
I'm available to try this in our project if it would be helpful in moving it along. I did try bringing in the sbaobab.d.ts file, but typescript (v3.8.3) complained on a number of lines. For example:
and
|
@jrust easiest thing is probably Option 2 is to Option 3 is to try https://github.com/qpwo/dentata (npm install dentata) which I just published today actually - it's basically a limited subset of baobab meant to improve the typescript inferencability and be a bit faster potentially. |
No description provided.