MachXO3D fuzzers #219
Merged
MachXO3D fuzzers #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now ready to be reviewed, and feature supported are same as on MachXO3 |
gatecat
reviewed
Aug 18, 2023
gatecat
reviewed
Aug 18, 2023
| @@ -147,7 +151,7 @@ class BitstreamReadWriter { | |||
|
|
|||
| // Decompress and copy multiple bytes into an OutputIterator and update CRC | |||
| template<typename T> | |||
| void get_compressed_bytes(T out, size_t count, array<uint8_t, 8> compression_dict) { | |||
| void get_compressed_bytes(T out, size_t count, array<uint8_t, 16> compression_dict) { | |||
There was a problem hiding this comment.
this all looks nicely done, but for peace of mind can you double check a compressed bitstream still works on an ecp5 with these changes?
There was a problem hiding this comment.
Did this while working on PR, but will do it again.
There was a problem hiding this comment.
Checked right with couple of bitstreams now on ULX3S board, all fine.
|
Have resolved issue with conflicting database now, so it is ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fuzzers for MachXO3D based on those from MachXO3