Implemented 'ODataPropertyName' attribute #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will this get approved? |
@BarberMSFT I've published my patched version to nuget, you can use it while this PR is not merged. |
|
|
@ZEXSM Looks like your ci pipeline doesn't have the "CONFIGURATION" variable set. |
|
@pikami, checked, she is there, I'm still figuring out what the problem is |
ZEXSM
approved these changes
May 16, 2024
|
@pikami try |
|
@ZEXSM Just checked, it works as expected. |
|
@pikami, try merge PR |
|
Only those with write access can merge pull requests. |
|
was out last week but awesome work, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be cases when the model in the OData service is different from the model in the application. In those cases we need a way to override the property names of our model to match those in the OData service.
This PR adds support for custom property names during query building by using a new 'ODataPropertyName' attribute.
This fixes and or provides workarounds the following issues:
While I believe this feature can be beneficial in certain scenarios, I do acknowledge that it may not be the most elegant or intuitive solution. I'm more than open to discussing alternative approaches that might better align with this library's design philosophy.