Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(music): rename event names for connect and disconnect #1127

Merged
merged 3 commits into from
Jul 1, 2024
Merged

fix(music): rename event names for connect and disconnect #1127

merged 3 commits into from
Jul 1, 2024

Conversation

xayanide
Copy link
Member

Thank you for your interest in contributing!

Before proceeding, please review the guidelines for contributing.

  • Are you targeting the next branch? (left side)
  • Did you review the guidelines for contributing?
  • Does your code pass linting checks?
  • Is your code documented, if applicable? (Check if not applicable)
  • Does this PR have a linked issue?

Scope of change

  • Major change
  • Minor change
  • Documentation only

Type of change

  • Bug fix
  • Feature
  • Other

Priority

  • Critical
  • High
  • Medium
  • Low

Description

Please describe the changes.
Closes #1123
Renames the deprecated event names being listened to by the Lavaclient event handlers.
connect to connected
disconnect to disconnected
Should resolve the issue where there is no indication whether Lavalink has connected or disconnected.

@xayanide xayanide added type:enhancement Issues and PRs: Related to adding or improving something pr:type:fix PRs: Fix status:tested PRs: Tested and working with no issues status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added labels Apr 12, 2024
@xayanide xayanide self-assigned this Apr 12, 2024
@xayanide xayanide requested a review from a team as a code owner April 12, 2024 11:17
@xayanide xayanide removed their assignment Apr 12, 2024
@zptx-bot zptx-bot enabled auto-merge (squash) April 12, 2024 11:17
@github-actions github-actions bot added the priority:p3 Issues and PRs: Low priority label Apr 12, 2024
@xayanide xayanide added type:bug Issues and PRs: Related to a bug branch:next Issues: Impacts next branch and removed priority:p3 Issues and PRs: Low priority branch:next Issues: Impacts next branch labels Apr 12, 2024
@xayanide xayanide removed their assignment Apr 12, 2024
@xayanide xayanide linked an issue Apr 12, 2024 that may be closed by this pull request
Lavaclient event handlers listening to deprecated event names #1123
Open
2 tasks
zapteryx
zapteryx approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@zapteryx zapteryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zptx-bot zptx-bot merged commit 302901b into ZPTXDev:next Jul 1, 2024
8 checks passed
zptx-bot pushed a commit that referenced this pull request Jul 1, 2024
@semantic-release-bot
chore(release): 7.0.2-next.2
16aec8f 
## [7.0.2-next.2](7.0.2-next.1...7.0.2-next.2) (2024-07-01)

### Bug Fixes

* **music:** rename event names for connect and disconnect ([#1127](#1127)) ([302901b](302901b))
@zptx-bot
Copy link
Member

zptx-bot commented Jul 1, 2024

🎉 This PR is included in version 7.0.2-next.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

zptx-bot pushed a commit that referenced this pull request Jul 1, 2024
@semantic-release-bot
chore(release): 7.0.2
ddbced0 
## [7.0.2](7.0.1...7.0.2) (2024-07-01)

### Bug Fixes

* **cmd-247:** incorrect output on toggle ([#1128](#1128)) ([5696bb5](5696bb5))
* **music:** rename event names for connect and disconnect ([#1127](#1127)) ([302901b](302901b))
* ts-ignore random stuff ([fdb2d3a](fdb2d3a))
@zptx-bot
Copy link
Member

zptx-bot commented Jul 1, 2024

🎉 This PR is included in version 7.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zapteryx zapteryx zapteryx approved these changes

Assignees

@zapteryx zapteryx

Labels
pr:type:fix PRs: Fix released on @next released status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added status:tested PRs: Tested and working with no issues type:bug Issues and PRs: Related to a bug type:enhancement Issues and PRs: Related to adding or improving something
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lavaclient event handlers listening to deprecated event names
3 participants
@xayanide @zptx-bot @zapteryx