Run isort before and after autoflake. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78, #75
The proposed solution in #78 was to swap the order of isort and autoflake, but this doesn't currently work because you run into PyCQA/autoflake#106 (which I think is the reason why it's currently the way around that it is). Running isort, then autoflake, then isort again, seems to be sufficient to solve this problem.
I looked into a more sophisticated solution which treats this as a running multiple passes to their collective fixed point, and it worked fine but didn't seem to have any real benefit to it and was a bit messier than what was currently here, so this just takes the simplest approach that will work.