feat: add support for rgbcw bulbs #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bulbs with hardware version 0x0e are RGBCW bulbs which are currently unsupported. add support for these types of bulbs and enable setting the color temperature directly, transforming between mired (micro-reciprocal degrees) as used by HomeKit and white values, rather than transforming HSL values.
ali-hk
commented
Oct 21, 2023
| !this.myDevice.lightParameters.hasCCT && | ||
| this.lightState.HSL.luminance > 0 && | ||
| this.lightState.isOn | ||
| ) { | ||
| this.updateLocalBrightness(this.lightState.HSL.luminance * 2); |
There was a problem hiding this comment.
It's unclear to me why the local brightness value gets updated here, but this seems to cause HomeKit to show the wrong color value when navigating away and back to the accessory settings, if the color value was set to a color temperature rather than RGB, so I've added a condition to skip it for CCT cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bulbs with hardware version 0x0e are RGBCW bulbs which are currently unsupported. add support for these types of bulbs and enable setting the color temperature directly, transforming between mired (micro-reciprocal degrees) as used by HomeKit and white values, rather than transforming HSL values.