frost-client: fix error if there is no self contact #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While documenting the demo I found a bug; if you initialize fresh configs and run the DKG, it would fail, because it does not create a "self contact (i.e. a contact with your own public key), unlike what
trusted-dealerdoes.I think
trusted-dealeris wrong (but it's harmless) and a "self contact" should not be required. This changescontact_by_pubkey()to also search for the self pubkey. It puts an empty as the string, which is harmless enough (it makes an empty string appear infrost-client sessionsfor example, which we could handle better later).