-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update demo docs for user registration #721
Conversation
Visit the preview URL for this PR (updated for commit 412dd01): https://frost-book--pr721-docs-user-registrati-lkb5ck4q.web.app (expires Wed, 28 Aug 2024 16:44:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7f43333fbf8fa5527ab3f0dd7bd10bb1fa7401c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, I think the order of actions to be taken by users could be improved a bit, e.g you need to run the participant commands to generate and send the commitments before you can paste the SIGHASH for the message to be signed.
Also, I got an InvalidExternalSignature
error when pasting the group signature into the sign command but I think this was probably due to user error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I re-tested the flow and it seems the work, the invalid signature error was probably caused by not using the same keys that were used to generate the address (this could happen if you generated them again after you generated the address)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This should merge only after ZcashFoundation/frost-zcash-demo#252 gets merged