Add Blake2b512 trait #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to provide their own implementation of BLAKE2b-512. Important for hardware wallet support as they have their own, optimized implementations of BLAKE2b-512.
|
Closing since it's oudated, pointed to this in ZcashFoundation/reddsa#62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to provide their own implementation of BLAKE2b-512. Important for hardware wallet support as they have their own, optimized implementations of BLAKE2b-512.
See #24 for detailed rationale and discussion about which the
Blake2b512trait (andStdBlake2b512implementation) should be added to.