Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 port #19

Open
wants to merge 1 commit into
base: ros1
Choose a base branch
from
Open

ROS2 port #19

wants to merge 1 commit into from

Conversation

ruffsl
Copy link

@ruffsl ruffsl commented Jun 18, 2021

You may want to audit the dependency list. Feel free to change target branch to something like ros2.

@erelson
Copy link
Collaborator

erelson commented Jun 23, 2021

@ruffsl thanks for the two PRs, and I saw the comments on the fetch_gazebo issue. (was out on vacation last week)

I can definitely create ros2 branches on these message repos and merge these. Would a ROS2 package release (what distro?) be needed as well, or are you mayeb e.g. building from source in docker images?

@ruffsl
Copy link
Author

ruffsl commented Jun 23, 2021

We are currently building this from source, but a distro release of these packages would be appreciated. That could really simplify the ros1 bridge setup process, forgoing the need to compile the fetch message packages separately within an underlay workspace.

I think this package should build successfully for foxy, galactic, and rolling. Like I said though, you may want to audit the package XML and cmake dependencies, and verify what is minimally necessary.

@erelson
Copy link
Collaborator

erelson commented Jun 23, 2021

Yeah, I'll do my best to test this before doing a release in the near future for you 👍. Just FYI, no concrete ROS 2 plans to share at the moment. These packages are easy to work with though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants