-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Clock + Volume sliders in top right #769
base: master
Are you sure you want to change the base?
Conversation
Turn the interface_root Controls into Panels so they draw as rectangles, then you can better see the structure of the menu. My recollection is that the button on the top right are in a control with the username, so it would make sense to put the volume control there. On the slider itself, I become more concerned about the top right of the screen having too much packed into it. I have considered making Settings and Friends main menu options and turning the remaining big texty buttons into icons. The 'Home' button is redundant with the home button in the community tab and the logout button could become more integrated with the username, and look less like the big X in the top right of the application. |
That is insufficiently all-encompassing. |
[settings] Make Lobby Music Volume trackbar update periodically [settings] Added Master Volume trackbar Moving panels around
Attempts to add a little bit of convenient GUI parity from in-game to the lobby, in the form of main+music volume sliders and a clock.
I'll probably need to modify
gui_settings_window.lua
to refresh itsMenu Music Volume
slider, and I'll strip a lot of the commented out code before it's ready to merge, but for now I'd like some advice on making it fit the layout properly. As-is, I had to settle on what felt like hacky position values to get it to sit roughly where I wanted it, but I suspect there's a proper way of making it conform.