Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Clock + Volume sliders in top right #769

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Birdulon
Copy link

@Birdulon Birdulon commented Oct 8, 2020

Attempts to add a little bit of convenient GUI parity from in-game to the lobby, in the form of main+music volume sliders and a clock.
image
I'll probably need to modify gui_settings_window.lua to refresh its Menu Music Volume slider, and I'll strip a lot of the commented out code before it's ready to merge, but for now I'd like some advice on making it fit the layout properly. As-is, I had to settle on what felt like hacky position values to get it to sit roughly where I wanted it, but I suspect there's a proper way of making it conform.

@GoogleFrog
Copy link

Turn the interface_root Controls into Panels so they draw as rectangles, then you can better see the structure of the menu. My recollection is that the button on the top right are in a control with the username, so it would make sense to put the volume control there.

On the slider itself, I become more concerned about the top right of the screen having too much packed into it. I have considered making Settings and Friends main menu options and turning the remaining big texty buttons into icons. The 'Home' button is redundant with the home button in the community tab and the logout button could become more integrated with the username, and look less like the big X in the top right of the application.

@Birdulon
Copy link
Author

image
Hacked around with it a bit more and got it looking like this (haven't committed yet as of this comment). Is this in line with what you were thinking?

@GoogleFrog
Copy link

That is insufficiently all-encompassing.

@GoogleFrog
Copy link

I've been thinking something like this:
image

Basically, the top right is a mess and needs a redesign. Maybe in that redesign there would be space for volume sliders. I don't want to pile issues onto it before the redesign is underway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants