Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use shared Graph code #24

Merged
merged 5 commits into from
Aug 25, 2024
Merged

Refactor to use shared Graph code #24

merged 5 commits into from
Aug 25, 2024

Conversation

dabreegster
Copy link
Collaborator

This cuts over to share https://github.com/a-b-street/15m/tree/main/graph with the 15m tool, towards the first use case of a-b-street/15m#17.

  • Much less code here, and the abstractions over in the common Graph crate fit nicely here
  • Routes shown here have precise positions along roads now
  • I spotted some cases around UTD where an individual route looked more correct with the changes
  • Score mode looks a bit different before/after, but really need to do Generate better desire lines #22 before polishing results here more

This unlocks doing #18 quite easily as a next step

@dabreegster dabreegster merged commit e9d40bd into main Aug 25, 2024
@dabreegster dabreegster deleted the use_graph branch August 25, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant