Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
About the refactor:
The main idea behind the reactor is to keep a clean and modular code. The previous
robot.launch.py
was growing rapidly in complexity and getting difficult to follow and navigate, for that reason the launch system was breakdown into sub-components:state_publisher.launch.py
sim_gazebo.launch.py
controller.launch.py
start_rviz.launch.py
In addition to the re-structuring the whole launch system was changed to use
OpaqueFunctions
, the idea behind them is to be able to evaluateLaunchConfiguration
at runtime. Example:For launch the robot description as
urdf
we usexacro.process_file
from ros xacro, the main problem arises when you want to convert launch arguments to xacro arguments.side node related with
xacro.process_file
, the key-word argumentmappings
is not document and required knowledge about the source code.Bug Fixes