Merge pull request activist-org#924 from aasimsyed/fix/typo-in-locator

fix typo in button locator and update test
aasimsyed · Jul 5, 2024 · 49f4671 · 49f4671
2 parents bf75016 + c8bc794
commit 49f4671
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 19 deletions.
diff --git a/frontend/package.json b/frontend/package.json
@@ -20,7 +20,7 @@
     "@nuxtjs/i18n": "^8.3.0",
     "@nuxtjs/tailwindcss": "^6.11.4",
     "@pinia/nuxt": "^0.5.1",
-    "@playwright/test": "^1.44.0",
+    "@playwright/test": "^1.45.1",
     "@types/node": "^20.12.5",
     "@types/uuid": "^9.0.8",
     "@types/zxcvbn": "^4.4.4",
@@ -32,7 +32,7 @@
     "eslint-plugin-vuejs-accessibility": "^2.2.1",
     "nuxt": "^3.11.2",
     "nuxt-icon": "^0.6.10",
-    "playwright": "1.44.0",
+    "playwright": "1.45.1",
     "prettier": "^3.2.5",
     "prettier-plugin-tailwindcss": "^0.5.13",
     "rollup": "^4.14.1",
@@ -74,6 +74,6 @@
     "zxcvbn": "^4.4.2"
   },
   "resolutions": {
-    "playwright-core": "1.44.0"
+    "playwright-core": "1.45.1"
   }
 }
diff --git a/frontend/tests/page-objects/LandingPage.ts b/frontend/tests/page-objects/LandingPage.ts
@@ -10,7 +10,7 @@ export default class LandingPage extends BasePage {
     GET_ORGANIZED_BUTTON: "#btn-get-organized",
     GROW_ORGANIZATION_BUTTON: "#btn-grow-organization",
     ABOUT_BUTTON: "#btn-activist",
-    BECOME_SUPPORTER_BUTTON: "btn-become-supporter",
+    BECOME_SUPPORTER_BUTTON: "#btn-become-supporter",
     OUR_SUPPORTERS_BUTTON: "#btn-our-supporters",
   };
 

diff --git a/frontend/tests/specs/landing-page.spec.ts b/frontend/tests/specs/landing-page.spec.ts
@@ -136,6 +136,7 @@ test.describe("Landing Page", () => {
     await expect(landingPage.getOrganizedButton).toBeVisible();
     await expect(landingPage.growOrganizationButton).toBeVisible();
     await expect(landingPage.aboutButton).toBeVisible();
+    await expect(landingPage.becomeSupportersButton).toBeVisible();
     await expect(landingPage.ourSupportersButton).toBeVisible();
   });
 });
diff --git a/frontend/yarn.lock b/frontend/yarn.lock
@@ -1663,12 +1663,12 @@
   dependencies:
     "@types/geojson" "*"
 
-"@playwright/test@^1.44.0":
-  version "1.44.0"
-  resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.44.0.tgz#ac7a764b5ee6a80558bdc0fcbc525fcb81f83465"
-  integrity sha512-rNX5lbNidamSUorBhB4XZ9SQTjAqfe5M+p37Z8ic0jPFBMo5iCtQz1kRWkEMg+rYOKSlVycpQmpqjSFq7LXOfg==
+"@playwright/test@^1.45.1":
+  version "1.45.1"
+  resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.45.1.tgz#819b90fa43d17000fce5ebd127043fd661938b7a"
+  integrity sha512-Wo1bWTzQvGA7LyKGIZc8nFSTFf2TkthGIFBR+QVNilvwouGzFd4PYukZe3rvf5PSqjHi1+1NyKSDZKcQWETzaA==
   dependencies:
-    playwright "1.44.0"
+    playwright "1.45.1"
 
 "@polka/url@^1.0.0-next.24":
   version "1.0.0-next.25"
@@ -3225,7 +3225,6 @@ braces@^3.0.3, braces@~3.0.2:
   integrity sha512-yQbXgO/OSZVD2IsiLlro+7Hf6Q18EJrKSEsdoMzKePKXct3gvD8oLcOQdIzGupr5Fj+EDe8gO/lxc1BzfMpxvA==
   dependencies:
     fill-range "^7.1.1"
-    fill-range "^7.1.1"
 
 browserslist@^4.0.0, browserslist@^4.22.2, browserslist@^4.23.0:
   version "4.23.0"
@@ -7795,17 +7794,17 @@ pkg-types@^1.0.3, pkg-types@^1.1.0, pkg-types@^1.1.1:
     mlly "^1.7.0"
     pathe "^1.1.2"
 
-playwright-core@1.44.0:
-  version "1.44.0"
-  resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.44.0.tgz#316c4f0bca0551ffb88b6eb1c97bc0d2d861b0d5"
-  integrity sha512-ZTbkNpFfYcGWohvTTl+xewITm7EOuqIqex0c7dNZ+aXsbrLj0qI8XlGKfPpipjm0Wny/4Lt4CJsWJk1stVS5qQ==
+playwright-core@1.45.1:
+  version "1.45.1"
+  resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.45.1.tgz#549a2701556b58245cc75263f9fc2795c1158dc1"
+  integrity sha512-LF4CUUtrUu2TCpDw4mcrAIuYrEjVDfT1cHbJMfwnE2+1b8PZcFzPNgvZCvq2JfQ4aTjRCCHw5EJ2tmr2NSzdPg==
 
-playwright@1.44.0:
-  version "1.44.0"
-  resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.44.0.tgz#22894e9b69087f6beb639249323d80fe2b5087ff"
-  integrity sha512-F9b3GUCLQ3Nffrfb6dunPOkE5Mh68tR7zN32L4jCk4FjQamgesGay7/dAAe1WaMEGV04DkdJfcJzjoCKygUaRQ==
+playwright@1.45.1:
+  version "1.45.1"
+  resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.45.1.tgz#aaa6b0d6db14796b599d80c6679e63444e942534"
+  integrity sha512-Hjrgae4kpSQBr98nhCj3IScxVeVUixqj+5oyif8TdIn2opTCPEzqAqNMeK42i3cWDCVu9MI+ZsGWw+gVR4ISBg==
   dependencies:
-    playwright-core "1.44.0"
+    playwright-core "1.45.1"
   optionalDependencies:
     fsevents "2.3.2"