Skip to content

Commit

Permalink
fix typo in button locator and update test
Browse files Browse the repository at this point in the history
<!---
Thank you for your pull request! 🚀
-->

<!-- Please replace the empty checkboxes [] below with checked ones [x] accordingly. -->

- [x] This pull request is on a [separate branch](https://docs.github.com/en/get-started/quickstart/github-flow) and not the main branch

---

<!--
Describe briefly what your pull request proposes to change. Especially if you have more than one commit, it is helpful to give a summary of what your contribution is trying to solve.

Also, please describe shortly how you tested that your change actually works.
-->
- added missing `#` in `"#btn-become-supporter"`
- updated test on Landing Page to check this button (was missing)
- ran Playwright test to confirm passed

<!--- activist prefers that pull requests be related to already open issues. -->
<!--- If applicable, please link to the issue by replacing ISSUE_NUMBER with the appropriate number below. -->
<!--- Feel free to delete this section if this does not apply. -->

- #ISSUE_NUMBER
  • Loading branch information
github-actions[bot] committed Jul 5, 2024
1 parent bf75016 commit 79a6a1b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion frontend/tests/page-objects/LandingPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default class LandingPage extends BasePage {
GET_ORGANIZED_BUTTON: "#btn-get-organized",
GROW_ORGANIZATION_BUTTON: "#btn-grow-organization",
ABOUT_BUTTON: "#btn-activist",
BECOME_SUPPORTER_BUTTON: "btn-become-supporter",
BECOME_SUPPORTER_BUTTON: "#btn-become-supporter",
OUR_SUPPORTERS_BUTTON: "#btn-our-supporters",
};

Expand Down
1 change: 1 addition & 0 deletions frontend/tests/specs/landing-page.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ test.describe("Landing Page", () => {
await expect(landingPage.getOrganizedButton).toBeVisible();
await expect(landingPage.growOrganizationButton).toBeVisible();
await expect(landingPage.aboutButton).toBeVisible();
await expect(landingPage.becomeSupportersButton).toBeVisible();
await expect(landingPage.ourSupportersButton).toBeVisible();
});
});

0 comments on commit 79a6a1b

Please sign in to comment.