Skip to content

Commit

Permalink
moved 'wait for web server' immediately after docker compose; removed…
Browse files Browse the repository at this point in the history
… 'docker down'
  • Loading branch information
aasimsyed committed May 4, 2024
1 parent 62acabd commit edb87a4
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions .github/workflows/pr_ci_playwright_e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ jobs:
- name: Run Docker Compose
run: docker compose --env-file .env.dev up --build -d

- name: Wait for web server to be ready
working-directory: ./frontend
run: |
curl --retry 20 --retry-delay 5 --retry-all-errors http://localhost:3000
- name: Setup Node environment
uses: actions/setup-node@v4
with:
Expand All @@ -44,11 +49,6 @@ jobs:
run: |
sudo yarn playwright install --with-deps
- name: Wait for web server to be ready
working-directory: ./frontend
run: |
curl --retry 15 --retry-delay 5 --retry-all-errors http://localhost:3000
- name: Run Playwright tests
working-directory: ./frontend
run: |
Expand All @@ -61,7 +61,3 @@ jobs:
name: playwright-report
path: frontend/playwright-report/
retention-days: 30

- name: Shutdown Docker Compose
if: always()
run: docker-compose down

0 comments on commit edb87a4

Please sign in to comment.