Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weeknumbers to calendar #45

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

nonpop
Copy link

@nonpop nonpop commented May 8, 2018

Hi, this preliminary PR adds week numbers to the calendar view. I can polish the code and add tests later, maybe even make it a minor release instead of major, but before any of that I'd like to know if you would be interested in merging such a feature in the first place.

@abadi199
Copy link
Owner

Hi @nonpop
Thanks for the PR. I think it's valuable to be able to show week number to the calendar, so I will definitely merge this once it's done. I don't have time to review the code right now, but at first glance, it looks like you're using different version of elm-format with what I'm using. Please upgrade the code to use elm-format@exp to keep the style consistent.

Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants