Skip to content

Commit

Permalink
Cleanup.
Browse files Browse the repository at this point in the history
Add contribution.
  • Loading branch information
abadi199 committed Sep 11, 2019
1 parent 1bedf68 commit 9afb6bd
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
16 changes: 13 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

This project is for exploring the idea of doing highly performant animation in Elm with a nice API.

It's presented at [Elm-Conf 2019](https://2019.elm-conf.com/speakers/abadi-kurniawan)
It's presented at [Elm-Conf 2019](https://2019.elm-conf.com/speakers/abadi-kurniawan) with the title: **Building Highly Performant Animations in Elm**



## Install all dependencies:
```
Expand All @@ -14,7 +16,6 @@ npm install
npm run slide
```
and then go to http://localhost:2222
source

Source code: https://github.com/abadi199/elm-animation-exploration/tree/master/src/Slide

Expand Down Expand Up @@ -44,4 +45,13 @@ Source code: https://github.com/abadi199/elm-animation-exploration/tree/master/s
Source code: https://github.com/abadi199/elm-animation-exploration/tree/master/src/Css

### Web Animations API (including experimental library)
Source code: https://github.com/abadi199/elm-animation-exploration/tree/master/src/Js
Source code: https://github.com/abadi199/elm-animation-exploration/tree/master/src/Js

## Contribution
This is an experimental project, and doesn't support all types of animation yet. I'm interested to build and publish a more complete package, but I have a limited free time.

If you think this is a good idea and you're interested in collaborating to make this library a published Elm package, reach out to me at:
- Elm Community Slack: @abadi199
- Twitter: @abadikurniawan
- or open an issue here: https://github.com/abadi199/elm-animation-exploration/issues/new

1 change: 0 additions & 1 deletion src/Css/Animation.elm
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ toAnimationStyle animation =
++ " "
++ Second.toString delayDuration
++ " forwards"
|> Debug.log "delay"

Sequence animations ->
hash animation ++ " " ++ Second.toString (getTotalDuration animations) ++ " forwards"
Expand Down
4 changes: 0 additions & 4 deletions src/Js/Main.elm
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,6 @@ updateReady : Msg -> Data -> ( Model, Cmd Msg )
updateReady msg data =
case msg of
AnimationFinish ->
let
_ =
Debug.log "AnimationFinish" ""
in
( Ready data, Cmd.none )

UserCheckShowShadowCheckBox checked ->
Expand Down

0 comments on commit 9afb6bd

Please sign in to comment.