Remove list extra dependency #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2018 10:45
In favour of copying the one function that we need locally. This means that we don't need the dependency in our elm-package.json file and do not need to release updates to keep up with releases of the List.Extra package.
That module has been moved to another project at this point. The tests still do not run but I'm not sure why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found it tricky to update my project to use a newer version of List.Extra and I think it is because of the limiting version parameters in this project's
elm-package.json. I thought to do a pull request which bumped the List.Extra upper-bound to 8.0.0 but as the code only uses one function from List.Extra it seemed reasonable to copy that function into this code base and drop the dependency entirely to avoid future trouble.I hope that seems reasonable. I'm very grateful for this project and the work you've done on it. I use the
MultiSelectmodule in my work. I realise I've presented this PR without any prior communication but as it is only a small amount of work I thought I would do it. Of course I understand if you'd rather approach it differently.I couldn't get the tests to run as they were referencing DatePicker which has been moved? Even with those tests removed, it doesn't compile. Possibly due to a glitch on my side. I'm not sure.
Thanks again.