Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Doubled Message Broadcast #24

Merged
merged 2 commits into from
Jul 3, 2020
Merged

[hotfix] Doubled Message Broadcast #24

merged 2 commits into from
Jul 3, 2020

Conversation

nickciolpan
Copy link
Contributor

The input message is broadcasted multiple times, provoking undesired cross-browser behaviour.

Steps to reproduce:

  • Go to the demo (preferably FF)
  • Add a debug statement before the message broadcast (\w Debug.log)
  • Press any key, other than aflanumeric
  • Press a number
  • Observe in the console the number of times it is called

Escalation:

  • On Firefox, at times, it duplicates the input

It solves:

@abadi199
Copy link
Owner

abadi199 commented Jul 3, 2020 •
edited
Loading

Thanks for the PR 💯 🎉

@abadi199 abadi199 merged commit 1741295 into abadi199:master Jul 3, 2020
@abadi199
Copy link
Owner

abadi199 commented Jul 3, 2020 •
edited
Loading

Published as v5.2.4

@abadi199 abadi199 mentioned this pull request Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickciolpan @abadi199