Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix masked input error #25

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Fix masked input error #25

merged 1 commit into from
Nov 24, 2020

Conversation

0ui
Copy link
Contributor

@0ui 0ui commented Oct 14, 2020

Updates avh4/elm-diff to jinor/elm-diff which fixes #19

Steps to reproduce:

  • Go to the live demo
  • In the Masked Text Input, type "(" twice and then try to delete it all with backspace
  • The characters "((" cannot be deleted

The problem with the old one was that it would interpret hitting backspace at the end of "(((" to make "((" as deleting the first character instead the last.

[Removed "(",NoChange "(("]

This is fixed with the other library which interprets as expected

[NoChange "((", Removed "("]

Cheers

@Natim
Copy link

Natim commented Nov 23, 2020

I'm in for that !

@abadi199 abadi199 merged commit 62ab4d9 into abadi199:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-input character in MaskedText input cannot be deleted resulting in unrecoverable state
3 participants