Provide data model #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a merge of @NodeJSmith's move_event_socket_to_app_manager branch.
|
Finally...my last PR. :-) |
|
Thanks a lot for all the effort, but same as with the other PRs, this has a lot of duplicated changes from the other PRs. |
|
Here’s a comparison between this PR branch and the previous PR branch:
�
lllucius@device_registry...lllucius:whirlpool-sixth-sense:provide_data_model
�
�
From: Abílio Costa ***@***.***>
Sent: Friday, January 10, 2025 5:01 PM
To: abmantis/whirlpool-sixth-sense ***@***.***>
Cc: Leland Lucius ***@***.***>; Author ***@***.***>
Subject: Re: [abmantis/whirlpool-sixth-sense] Provide data model (PR #76)
�
As with the other PRs, this has a lot of duplicated changes from the other PRs
—
Reply to this email directly, view it on GitHub <#76 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYB5CHD7VPBQUYUVWYDG7D2KBGKTAVCNFSM6AAAAABU6PLZN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBUGY4DSMJQGU> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/ABYB5CAMVPPO3OVJ4LTGVKD2KBGKTA5CNFSM6AAAAABU6PLZN2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2B445C.gif> Message ID: ***@***.*** ***@***.***> >
|
|
Getting a bit difficult to maintain here and would rather just resubmit a clean PR after the other 2 have been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes need to provide basic data model support. It's enough for Home Assistant anyway.