Stop re-raising exception on dead websocket. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dn0
added a commit
to erigones/gevent-socketio
that referenced
this pull request
Sep 3, 2016
…ing changes/merge requests:
* Setting Content-Length Headers to Strings - abourget#241 (by https://github.com/richardardrichard)
* Stop re-raising exception on dead websocket - abourget#240 (by https://github.com/richardardrichard)
* Fixed import to support Django>=1.9 - abourget#236 (by https://github.com/chrisspen)
* Fix cfg_addr error on socket object - copied from abourget#200 (by https://github.com/shuoli84)
* Fixes unicode error with newest gevent - abourget#221 (by https://github.com/bobvandevijver)
* Fixes memory leak issue - abourget#225 (by https://github.com/chrismeyersfsu)
* Full Python 2+3 support - commit 12da966 (by https://github.com/Eugeny)
* Travis script fix - commit 13cd65e (by https://github.com/Eugeny)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-raising the exception in transports.py means that socket.disconnect() will never be called. This also seems to have the side effect of raising an exception whenever someone doesn't cleanly disconnect the websocket.
It looks like this was added as a part of this commit: 12da966