-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store and display new Package.risk_score
field in the UI
#194
Conversation
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Package.risk_score
field in the UI
@tdruez All of your Changes confirmed in Staging Starship. The placement and appearance of the Risk Score is very nice! I agree with your Note about what it applies to, and yes we need to discuss more "An item to discuss is that the Risk score applies to Package entries where the Weighted Severity, Exploitability apply to Vulnerability entries." since I think the VulnerableCode effort there needs clarification. One problem: The tool tips (flyover help) on all the column headings of the Product Inventory tab are suddenly missing, although they work fine in the other tabs. |
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
The tooltips never were available on the "Inventory" tab, I've added those. New changes:
Questions/Discussions:
I've used the following for now but I doubt it make sense:
Let's define the proper range for this filter. |
@tdruez In principle (theory) the Exploitability will only be one of these 3 values: 0.5, 1.0, 2.0 |
@tdruez everything looks good on Staging Starship except for one problem, where on a Product Inventory tab I attempted to filter by Risk; if I select any of the filter values I get a "Fetching Inventory" message with a spinning circle that goes into infinite loop. |
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
This was not clear as the design document mentioned a range and not fixed values:
The filter is now set to the 3 choices: 0.5, 1.0, 2.0 See #97 (comment) for some discussion on improving the display of |
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
@DennisClark The Please have another look at this implementation in DejaCode of the new fields: |
@tdruez The updates look very good, but I am still having the problem I mentioned in a previous comment where on a Product Inventory tab I attempted to filter by Risk; if I select any of the filter values I get a "Fetching Inventory" message with a spinning circle that goes into infinite loop. The problem occurs on Staging in both Starship and nexB dataspaces (see product ScanCode.io 33.0.0-dev as an example). |
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
@DennisClark This is now available on all instances. |
For reference, here is the markdown export of the Gdoc at https://docs.google.com/document/d/1SRAkvoIj18quuRSap1r8-R6TMHAVPRPi/edit#heading=h.ll22skp48ksm : CRAVEX: Managing-Vulnerabilities-in-DejaCodeThis design is ready for review. CRAVEX project: See https://github.com/orgs/aboutcode-org/projects/8/views/1 Background {#background}Objective: Use Vulnerability Risk, Weighted Severity and Exploitability values from VulnerableCode to manage vulnerabilities in DejaCode. Related GitHub issues:
Update DejaCode Packages with Vulnerability Scores {#update-dejacode-packages-with-vulnerability-scores}DejaCode has a process that updates Packages with VulnerableCode data on a routine scheduled basis (such as daily). This makes vulnerability data fields available to the DejaCode user in Package and Product Package Queries. Rather than max_score and min_score, DejaCode should be improved to get three new score values supported by aboutcode-org/vulnerablecode#1543 and #97 :
These scores support the DejaCode user’s ability to prioritize review and determine action when reviewing Packages and Product Packages. DejaCode should also set the Vulnerability Status (see next section) to “Under Investigation” when a Vulnerability is initially discovered for a Package. Vulnerability Status {#vulnerability-status}introduce a "Vulnerability Status" table to define status codes that can be applied to Package and Product Package. (We need one anyway to support VEX.) Reference Data Values (fixture values) should be
and the standard VEX Status values as defined for the “state” field in the CDX VEX spec: https://cyclonedx.org/docs/1.6/json/#vulnerabilities_items_analysis
Add the Vulnerability Status field to the Package and Product Package models. DejaCode Product Package Relationship {#dejacode-product-package-relationship}Introduce Vulnerability Status to the Product Package Relationship. Note that it refers to the Vulnerability Status within the context of the Relationship. When a new Product Package is created in DejaCode, set the Vulnerability Status to be the same as the one identified in the corresponding Package. DejaCode Packages UI {#dejacode-packages-ui}The Vulnerabilities tab of the Packages detail user view in DejaCode currently is a grid with the following columns: Affected by, Aliases, Score, Summary, Fixed Packages. This should be improved to replace the Score column (which currently shows a Severity range) with three new columns that provide the Weighted Severity, Exploitability, and Vulnerability Risk score values. Enable sorting and filtering on those columns. DejaCode Product UI {#dejacode-product-ui}Product Inventory Tab {#product-inventory-tab}The Product Inventory tab in DejaCode currently is a grid with the following columns: Item, Purpose, Concluded license, Review status, Deployed, Modified. This should be improved to:
Apply the label name change, and introduce the new “Vulnerability status” field, in the “Update relationship” form. Product Vulnerabilities Tab {#product-vulnerabilities-tab}The Product Vulnerabilities tab in DejaCode currently is a grid with the following columns: Vulnerability, Aliases, Score, Summary, Affected packages. This should be improved to replace the Score column (which currently shows a Severity range) with three new columns that provide the Weighted Severity, Exploitability, and Vulnerability Risk score values. Enable sorting and filtering on those columns. The Vulnerabilities tab on Product could possibly highlight specific items based on their Risk value: 8.0 - 10.0 Critical, immediate response required (red?) 6.0 - 7.9 High, response required as soon as possible (orange?) 3.0 - 5.9 Medium, investigation required (yellow?) 0.1 - 2.9 Low, response deferred (no highlight) Also we can use the ranges defined above for filtering by Risk. |
Following https://docs.google.com/document/d/1FxeJLATdlrsDZspwByXgh5Wc_Vp83qNp/ and https://docs.google.com/document/d/1SRAkvoIj18quuRSap1r8-R6TMHAVPRPi/
Changes:
risk_score
field added on the Package/Component modelsNotes:
In the Context of a Vulnerabilities list/table, it does not make sense as a column.
An item to discuss is that the Risk score applies to
Package
entries where the Weighted Severity, Exploitability apply toVulnerability
entries.The cannot be displayed the same way (single value column) depending on the context: Package listing or Vulnerability listing.
Database changes:
Migrations for 'component_catalog':
Migrations for 'vulnerabilities':