Use constexpr in container algorithm #1880
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly this passes Abseil's tests but breaks almost our entire monorepo in certain cases where |
@derekmauro Hi, can you share some example with compiler/stdlib/std version if possible? |
|
I'm pretty sure the problem is not the fault of your change. I think there are a handful of users that have non-compliant code that I will need to fix first. |
|
Ok, thanks for explaining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/llvm/llvm-project/blob/main/libcxx/include/algorithm
checked with llvm libc++19 and clang19 (only algorithms which support constexpr since c++20)