-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMQ-2609 - Remove DomainUserID encoding from session and authn #2688
Open
felixgateru
wants to merge
3
commits into
absmach:main
Choose a base branch
from
felixgateru:smq2609
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
==========================================
- Coverage 42.03% 36.30% -5.74%
==========================================
Files 347 248 -99
Lines 47929 41297 -6632
==========================================
- Hits 20146 14992 -5154
+ Misses 25582 25164 -418
+ Partials 2201 1141 -1060 ☔ View full report in Codecov by Sentry. |
arvindh123
requested changes
Feb 11, 2025
7512024
to
47452d5
Compare
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
@arvindh123 @felixgateru What's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor as it remove DomainUserID encoding.
What does this do?
This pr removes DomainUserID encodinh and makes all authorization on entities to be performed with userID.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have updated tests.
Did you document any new/modified feature?
No,
Notes
None