NOISSUE - Enable UI prefix when running behind reverse proxy #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmuchyri
requested changes
Feb 19, 2025
dborovcanin
force-pushed
the
mg-495-UIPrefix
branch
from
87251a1 to
8e134d8
Compare
Musilah
force-pushed
the
mg-495-UIPrefix
branch
from
8e134d8 to
5f88403
Compare
arvindh123
requested changes
Feb 25, 2025
| @@ -138,6 +138,23 @@ http { | |||
| include snippets/ws-upgrade.conf; | |||
| proxy_pass http://ws-adapter:${SMQ_WS_ADAPTER_HTTP_PORT}/; | |||
| } | |||
|
|
|||
| # Proxy Pass to the Magistrala UI | |||
There was a problem hiding this comment.
Please align this line with other
Comment on lines
+333
to
+335
| - ui | ||
| - ui-backend |
There was a problem hiding this comment.
There is no ui or ui-backend in this docker-compose
| @@ -125,6 +125,23 @@ http { | |||
| include snippets/ws-upgrade.conf; | |||
| proxy_pass http://ws-adapter:${SMQ_WS_ADAPTER_HTTP_PORT}/; | |||
| } | |||
|
|
|||
| # Proxy Pass to the Magistrala UI | |||
| location /ui/ { | |||
There was a problem hiding this comment.
In Docker Compose file currently doesn't include ui or ui-backend, so Nginx won't start properly until all the endpoints are accessible. To make this PR functional, we need to add ui and ui-backend to the Docker Compose configuration. Without these, this PR won't be effective.
There was a problem hiding this comment.
We will need to add them, as well. Similar to what we did for Magistrala. @Musilah Please take care of this.
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
dborovcanin
force-pushed
the
mg-495-UIPrefix
branch
from
5f88403 to
b0f27d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it enables UI prefix when running behind reverse proxy.
What does this do?
Enable UI prefix when running behind reverse proxy.
Now a user can reach the ui via :
http://ui:3000/Which issue(s) does this PR fix/relate to?
N/A
Have you included tests for your changes?
N/A
Did you document any new/modified feature?
N/A
Notes