feat: add jsonld schema support #1375
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ccb4fad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Handle single type | ||
| if (typeof typeSchema === "string") { | ||
| return { | ||
| ...(typeof this.schema === "object" ? this.schema : {}), |
There was a problem hiding this comment.
Bug: Array Spread Error in Schema Parsing
The typeof this.schema === "object" check in JsonLdTypeSchemaParser, JsonLdEntitySchemaParser, and JsonLdContextSchemaParser incorrectly spreads arrays into the returned object. Since arrays are also typeof "object", this results in numeric keys being added, potentially leading to malformed schema representations.
Additional Locations (5)
src/schema-parser/base-schema-parsers/jsonld-type.ts#L28-L30src/schema-parser/base-schema-parsers/jsonld-context.ts#L10-L12src/schema-parser/base-schema-parsers/jsonld-context.ts#L25-L27src/schema-parser/base-schema-parsers/jsonld-context.ts#L50-L52src/schema-parser/base-schema-parsers/jsonld-entity.ts#L21-L23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.