Skip to content

[timepoint_list] test plan #9689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[timepoint_list] test plan #9689

wants to merge 6 commits into from

Conversation

adamdaudrich
Copy link
Collaborator

Brief summary of changes

This is the timepoint permissions

I found this test confusing because of how it was written. After fully testing, I made it more point-by-point using markdown . I then updated it to the markdown style for github

@adamdaudrich adamdaudrich added Cleanup PR or issue introducing/requiring at least one clean-up operation Difficuly: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...) Module: timepoint_list PR or issue related to the timepoint_list module 27.0.0 - Bugs Bugs Found in LORIS 27 testing labels Mar 10, 2025
skarya22
skarya22 requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@skarya22 skarya22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates!

Left a few comments, but can you also change the wording to match other LORIS test plans? Instead of If _ the test passed could you change to Ensure __ or Press __ and confirm ___.

@skarya22 skarya22 added the State: Needs work PR awaiting additional work by the author to proceed label Mar 10, 2025
@adamdaudrich
Copy link
Collaborator Author

@skarya22 i'll go through these

@adamdaudrich adamdaudrich changed the title Timepoint perm test [timepoint] test plan Mar 13, 2025
@adamdaudrich adamdaudrich changed the title [timepoint] test plan [timepoint_list] test plan Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarya22 skarya22 skarya22 requested changes

@sruthymathew123 sruthymathew123 Awaiting requested review from sruthymathew123

Requested changes must be addressed to merge this pull request.

Assignees

@adamdaudrich adamdaudrich

Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Cleanup PR or issue introducing/requiring at least one clean-up operation Difficuly: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...) Module: timepoint_list PR or issue related to the timepoint_list module State: Needs work PR awaiting additional work by the author to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamdaudrich @skarya22