Skip to content

Commit

Permalink
Remove const ptr declaration from fromjstring/tojstring functions.
Browse files Browse the repository at this point in the history
I thought I had resolved the warning here in 8078536, but it is still a
warning when using `env` inside of these functions by passing them into
say `GetObjectClass` etc.

Removing `const` completely silences any warnings.

Related to #41
  • Loading branch information
aclemons committed Dec 12, 2024
1 parent 8078536 commit 73e5c52
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/native/org_gnu_readline_Readline.c
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,8 @@ static size_t bufLength = 0;

static char* word_break_buffer = NULL;

static char* fromjstring(JNIEnv const *env, jstring value);
static jstring tojstring(JNIEnv const *env, const char* value);
static char* fromjstring(JNIEnv *env, jstring value);
static jstring tojstring(JNIEnv *env, const char* value);

static int allocBuffer(size_t n);

Expand Down Expand Up @@ -776,7 +776,7 @@ JNIEXPORT jstring JNICALL
/* Convert jstring to c-string */
/* -------------------------------------------------------------------------- */

char* fromjstring(JNIEnv const *env, jstring value) {
char* fromjstring(JNIEnv *env, jstring value) {
const jclass jstringClass = (*env)->GetObjectClass(env, value);
const jmethodID getBytesMethodId = (*env)->GetMethodID(env, jstringClass, "getBytes", "()[B");

Expand Down Expand Up @@ -822,7 +822,7 @@ char* fromjstring(JNIEnv const *env, jstring value) {
/* Convert c-string to j-string */
/* -------------------------------------------------------------------------- */

jstring tojstring(JNIEnv const *env, const char* value) {
jstring tojstring(JNIEnv *env, const char* value) {
const jclass jstringClass = (*env)->FindClass(env,"java/lang/String");
const jmethodID constructorMethodId = (*env)->GetMethodID(env, jstringClass, "<init>", "([B)V");

Expand Down

0 comments on commit 73e5c52

Please sign in to comment.