Skip to content

Commit

Permalink
Merge pull request #1904 from acquia/ACMS-4288
Browse files Browse the repository at this point in the history
ACMS-4288: Fix GitLab CI pipelines of Drupal Starter Kit Modules.
  • Loading branch information
vishalkhode1 authored Oct 28, 2024
2 parents 78bd3fe + 34bddb2 commit a7176ad
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
2 changes: 2 additions & 0 deletions modules/acquia_cms_component/.gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ variables:
# Coverage report
ORCA_SUT_DIR: "$CI_PROJECT_DIR/../acquia_cms_component"
ORCA_JUNIT_LOG: "$CI_PROJECT_DIR/var/logs/junit.xml"
# Exclude the code coverage, as tests have not been written yet.
SKIP_ISOLATED_TEST_ON_CURRENT_COVERAGE_PHP83: 1
1 change: 0 additions & 1 deletion modules/acquia_cms_headless/.gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,3 @@ variables:

COMPOSER_PATCHES_FILE: $CI_PROJECT_DIR/.gitlab-ci/patches/patches.json
SKIP_INTEGRATED_TEST_ON_LATEST_EOL_MAJOR: 1
SKIP_INTEGRATED_TEST_ON_LATEST_EOL_MAJOR_PHP8: 1
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,15 @@ protected function assertNextJsEntityTypeConfigure(): void {
$assert = $this->assertSession();
$page = $this->getSession()->getPage();
$this->drupalGet("admin/config/services/next/entity-types/add");
$assert->selectExists('id')->selectOption('node.test');
$assert->waitForElementVisible('css', '.settings-container');
$assert->selectExists('Entity type')->selectOption('node.test');
$this->assertTrue($assert->optionExists('id', 'node.test')->isSelected());
$assert->buttonExists('Save')->press();
$this->drupalGet("admin/config/services/next/entity-types/node.test/edit");
$assert->waitForText('Settings');
$assert->waitForText('Configure draft mode for this entity type.');
$assert->selectExists('site_resolver')->selectOption('site_selector');
$assert->assertWaitOnAjaxRequest();
$assert->buttonExists('Save')->press();
$assert->waitForText('Next.js sites');
$this->assertTrue($assert->optionExists('site_resolver', 'site_selector')->isSelected());
$page->checkField('sites[headless_site_one]');
Expand Down
4 changes: 0 additions & 4 deletions modules/acquia_cms_site_studio/.gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,8 @@ variables:

# Site Studio 8.0.x doesn't support 9.5.x, hence skipping 9.5.x CI jobs now
SKIP_INTEGRATED_TEST_ON_LATEST_EOL_MAJOR: 1
SKIP_INTEGRATED_TEST_ON_LATEST_EOL_MAJOR_PHP8: 1

# Do not add patch for latest EOL Major i.e 9.5.x as it's working as expected.
INTEGRATED_TEST_ON_LATEST_EOL_MAJOR:
variables:
COMPOSER_PATCHES_FILE: ""
INTEGRATED_TEST_ON_LATEST_EOL_MAJOR_PHP8:
variables:
COMPOSER_PATCHES_FILE: ""

0 comments on commit a7176ad

Please sign in to comment.