ACMS-3354: Remove 10.2.x DIT patches from Acquia CMS Common module. #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshreeputra
requested review from
chandan-singh7929,
vishalkhode1,
apathak18 and
deepakmishra2
apathak18
approved these changes
Nov 23, 2023
|
@rajeshreeputra - Overall changes looks good to me, but I am getting error on my local when running |
|
Also, lets make sure that our CI run on next minor as well to see the actual failure for this PR. |
timplunkett
reviewed
Nov 26, 2023
rajeshreeputra
force-pushed
the
ACMS-3354
branch
2 times, most recently
from
44feb88 to
3a8b307
Compare
rajeshreeputra
force-pushed
the
ACMS-3354
branch
2 times, most recently
from
2d0621c to
8805947
Compare
chandan-singh7929
force-pushed
the
ACMS-3354
branch
3 times, most recently
from
9347e29 to
397edfc
Compare
rajeshreeputra
force-pushed
the
ACMS-3354
branch
4 times, most recently
from
8390fd8 to
d48fbd6
Compare
ACMS-3354: Ristrict ACMS Common 3.3.x to drupal core 10.1.x version.
vishalkhode1
force-pushed
the
ACMS-3354
branch
4 times, most recently
from
01fbedd to
6381603
Compare
ACMS-3393: Use chrome for testing(chromedriver) to run local test.
rajeshreeputra
force-pushed
the
ACMS-3354
branch
2 times, most recently
from
10cb310 to
de9efd5
Compare
rajeshreeputra
force-pushed
the
ACMS-3354
branch
from
de9efd5 to
5dc6e6b
Compare
vishalkhode1
force-pushed
the
ACMS-3354
branch
from
5dc6e6b to
485d562
Compare
…onfig as it's removed from Drupal Core 10.2.x.
…atch for drupal 1.2.x version.
vishalkhode1
force-pushed
the
ACMS-3354
branch
from
95d945b to
e84e27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3354
Proposed changes
Remove Drupal core patches as available in 10.2.x core.
Alternatives considered
NA
Testing steps
composer installMerge requirements