Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-3360: Re-export acms modules site studio packages. #1687

Merged
merged 12 commits into from
Dec 6, 2023

Conversation

chandan-singh7929
Copy link
Collaborator

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

@chandan-singh7929 chandan-singh7929 force-pushed the feature/site-studio-7.4.x branch from 3f998d0 to e4fb745 Compare November 30, 2023 12:13
@chandan-singh7929 chandan-singh7929 force-pushed the ACMS-3360 branch 2 times, most recently from 494c6b6 to 4570d44 Compare November 30, 2023 12:51
@chandan-singh7929 chandan-singh7929 force-pushed the feature/site-studio-7.4.x branch from e4fb745 to 5034c80 Compare November 30, 2023 12:55
@chandan-singh7929 chandan-singh7929 force-pushed the ACMS-3360 branch 2 times, most recently from 36c7b54 to a4742bd Compare December 1, 2023 09:16
@chandan-singh7929 chandan-singh7929 force-pushed the feature/site-studio-7.4.x branch 2 times, most recently from 0d3a431 to 4bc462f Compare December 1, 2023 13:48
@chandan-singh7929 chandan-singh7929 force-pushed the feature/site-studio-7.4.x branch 6 times, most recently from e11fd50 to ffaecea Compare December 5, 2023 13:48
@vishalkhode1 vishalkhode1 force-pushed the feature/site-studio-7.4.x branch 3 times, most recently from e4f63e7 to c3e70ee Compare December 6, 2023 09:00
@vishalkhode1
Copy link
Contributor

Changes looks good to me. The failing PHPUnit tests will be merged as part of ACMS-3366.

@vishalkhode1 vishalkhode1 merged commit aac5937 into feature/site-studio-7.4.x Dec 6, 2023
11 of 17 checks passed
@vishalkhode1 vishalkhode1 deleted the ACMS-3360 branch December 6, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants