Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACMS-3407: Validate feature/site-studio-7.4.x changes with stable release. #1693

Merged
merged 4 commits into from
Dec 13, 2023
Merged

ACMS-3407: Validate feature/site-studio-7.4.x changes with stable release. #1693

merged 4 commits into from
Dec 13, 2023

Conversation

chandan-singh7929
Copy link
Collaborator

@chandan-singh7929 chandan-singh7929 commented Dec 7, 2023 •
edited
Loading

Motivation

Fixes ACMS-3407

Proposed changes

Alternatives considered

Testing steps

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

@vishalkhode1 vishalkhode1 marked this pull request as ready for review December 7, 2023 09:18
@chandan-singh7929 chandan-singh7929 changed the title ACMS-3407: Validate feature site studio 7.4.x changes with stable rel… ACMS-3407: Validate feature/site-studio-7.4.x changes with stable release of SS 7.4 Dec 7, 2023
@chandan-singh7929 chandan-singh7929 changed the title ACMS-3407: Validate feature/site-studio-7.4.x changes with stable release of SS 7.4 ACMS-3407: Validate feature/site-studio-7.4.x changes with stable release. Dec 7, 2023
rajeshreeputra
rajeshreeputra requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@rajeshreeputra rajeshreeputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good, please take look at minor suggestions.

modules/acquia_cms_site_studio/composer.json Outdated Show resolved Hide resolved
modules/sitestudio_config_management/composer.json Outdated Show resolved Hide resolved
@chandan-singh7929 chandan-singh7929 requested review from apathak18 and removed request for Ankita180520 December 7, 2023 10:25
@chandan-singh7929 chandan-singh7929 force-pushed the ACMS-3407 branch 2 times, most recently from 25d13e9 to 0dc04cb Compare December 7, 2023 11:37
vishalkhode1
vishalkhode1 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@vishalkhode1 vishalkhode1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chandan-singh7929 chandan-singh7929 force-pushed the feature/site-studio-7.4.x branch from aac5937 to 85be512 Compare December 11, 2023 05:44
@chandan-singh7929 chandan-singh7929 force-pushed the ACMS-3407 branch 4 times, most recently from 2a04ab9 to 3e583c8 Compare December 11, 2023 09:23
@chandan-singh7929 chandan-singh7929 force-pushed the feature/site-studio-7.4.x branch from a6ce49d to 3c4db0a Compare December 13, 2023 07:51
@vishalkhode1 vishalkhode1 merged commit acd9d53 into feature/site-studio-7.4.x Dec 13, 2023
14 checks passed
@vishalkhode1 vishalkhode1 deleted the ACMS-3407 branch December 13, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeshreeputra rajeshreeputra rajeshreeputra approved these changes

@vishalkhode1 vishalkhode1 vishalkhode1 requested changes

@apathak18 apathak18 apathak18 approved these changes

@deepakmishra2 deepakmishra2 deepakmishra2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chandan-singh7929 @rajeshreeputra @vishalkhode1 @apathak18 @deepakmishra2