Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACMS-4246: Refactor Acquia Starter Kit Search to work with recipe. #1915

Merged
merged 18 commits into from
Jan 15, 2025
Merged

ACMS-4246: Refactor Acquia Starter Kit Search to work with recipe. #1915

merged 18 commits into from
Jan 15, 2025

Conversation

rajeshreeputra
Copy link
Contributor

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 27, 2024 13:10 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 30, 2024 07:06 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 30, 2024 07:37 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 30, 2024 07:56 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 30, 2024 08:05 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 30, 2024 09:51 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 30, 2024 12:13 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 30, 2024 14:00 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 30, 2024 14:11 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 31, 2024 08:46 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 31, 2024 08:50 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 31, 2024 09:04 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 31, 2024 10:36 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 31, 2024 10:44 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 31, 2024 10:58 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment January 14, 2025 09:00 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment January 14, 2025 09:13 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment January 14, 2025 10:34 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment January 14, 2025 13:10 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment January 14, 2025 13:15 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment January 15, 2025 08:56 — with GitHub Actions Inactive
chandan-singh7929
chandan-singh7929 reviewed Jan 15, 2025
View reviewed changes
modules/acquia_cms_search/config/optional/views.view.acquia_search.yml
- search_api
- text
- user
- acquia_cms_development
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check why dependency was added for acquia_cms_development

@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment January 15, 2025 09:20 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment January 15, 2025 09:24 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra changed the base branch from develop to feature/search-refactor January 15, 2025 09:25
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment January 15, 2025 09:40 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment January 15, 2025 10:27 — with GitHub Actions Inactive
@vishalkhode1 vishalkhode1 merged commit 4d43d8f into feature/search-refactor Jan 15, 2025
35 of 42 checks passed
@vishalkhode1 vishalkhode1 deleted the ACMS-4246-refactor branch January 15, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandan-singh7929 chandan-singh7929 chandan-singh7929 left review comments

@apathak18 apathak18 apathak18 left review comments

@vishalkhode1 vishalkhode1 Awaiting requested review from vishalkhode1

@deepakmishra2 deepakmishra2 Awaiting requested review from deepakmishra2

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajeshreeputra @chandan-singh7929 @apathak18 @vishalkhode1