-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acquire-zarr docs #93
base: main
Are you sure you want to change the base?
Conversation
I pushed changes to include the Python API to the Zarr library, but something is still wrong - the template I created to filter the attributed from the module is not working here. Might have somehting to do with how these objects are documented in the cpp file. I will investigate. Preview is updated: https://melissawm.github.io/acquire-docs/dev/stream_to_zarr/zarr_api/ |
Here's a preview of a proof of concept for using Doxygen/mkdoxy to add the C API docs to the site: https://melissawm.github.io/acquire-docs/stable/stream_to_zarr/ This is not ideal as there as several points I would like to improve:
|
8a84ee2
to
fd323c7
Compare
* Add Python and C API docs for acquire-zarr * Add doxygen-generated files to gitignore * Add Doxyfile for more configuration options * Remove unwanted items from docs
Hi all! I made some progress on the items we discussed last time.
After some testing, I realized that after building and installing acquire_zarr on python results in the docstrings for the various objects defined for the library to come from https://github.com/acquire-project/acquire-zarr/blob/main/python/acquire-zarr-py.cpp and NOT https://github.com/acquire-project/acquire-zarr/blob/main/python/acquire_zarr.pyi as I previously assumed. I'm not sure if this is a result of the build process or if acquire_zarr.pyi can be regenerated from the cpp file. In addition, the attributes for each class are called "Members" and as such create some confusion in the docstring formatting. Since I don't know exactly how to edit the cpp file directly to change this, we get some weird docstrings here: https://melissawm.github.io/acquire-docs/dev/stream_to_zarr/zarr_api/#acquire_zarr.CompressionCodec If you have any tips on how to solve this issue that would be great. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, just had one question.
{# {% with docstring_sections = module.docstring.parsed %} | ||
{% include "docstring"|get_template with context %} | ||
{% endwith %} | ||
{% endwith %} #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh - I made these into comments because I was trying to remove the module docstring from rendering, since we already have an intro on the page and that seemed more appropriate than the docstring. I can delete entirely since it seems this is the way to go.
Will close #92
Still working on autogeneration of API documentation.
PREVIEW: https://melissawm.github.io/acquire-docs/dev/stream_to_zarr/