Allow overwrite and ref targets. Adds more functionality / flexibility to action #14

thejeff77 · 2023-01-12T17:51:38Z

What this PR does / Why we need it

Adds two new optional variables:

ref: In case you want to target something other than HEAD
force: In case you want to move the tag. Great for walking tags.

Which issue(s) this PR fixes

Fixes #
#13
#12

remove runs-on param

mikesigs · 2023-03-02T18:41:31Z

README.md

+| `tag`        | A Git tag name.                        | `string` | `true`   | `N/A`   |
+| `message`    | A message for the Git tag.             | `string` | `false`  | `''`    |
+| `ref`        | Commit SHA or tag to target.           | `string` | `false`  | `''`    |
+| `force`      | A message for the Git tag.             | `boolean`| `false`  | `false` |


Fix description

Please fix desciption of the force paramater

mikesigs · 2023-03-02T18:42:25Z

README.md

+| `message`    | A message for the Git tag.             | `string` | `false`  | `''`    |
+| `ref`        | Commit SHA or tag to target.           | `string` | `false`  | `''`    |
+| `force`      | A message for the Git tag.             | `boolean`| `false`  | `false` |
+| `always-pass`| If step should pass if tag push fails  | `boolean`| `false`  | `false` |


always-pass sounds weird. ignore-failures maybe? Or always-succeed?

mikesigs · 2023-03-02T18:42:43Z

README.md

@@ -34,13 +37,13 @@ jobs:
      - uses: actions-ecosystem/action-get-latest-tag@v1
        id: get-latest-tag

-      - uses: actions-ecosystem/action-bump-semver@v1
+      - uses: thejeff77/action-bump-semver@v1.0.0


Use actions-ecosystem

+1 about use of actions-ecosystem
If you do a PR to original repo it should stay as is. In your own repo feel free to override it.

mikesigs · 2023-03-02T18:42:48Z

README.md

        id: bump-semver
        with:
          current_version: ${{ steps.get-latest-tag.outputs.tag }}
          level: minor

-      - uses: actions-ecosystem/action-push-tag@v1
+      - uses: thejeff77/action-push-tag@v1.0.0


Use actions-ecosystem

Same here. +1 about use of actions-ecosystem

mikesigs · 2023-03-02T18:43:23Z

action.yml

+name: Push Any Git Tag
+description: based on Actions Ecosystem Push Tag - Fixed with additional features.
+author: Actions Ecosystem & theJeff77


I wouldn't change these. Nor do you need to put your name in as the author just because you PR.

mikesigs · 2023-03-02T18:44:13Z

action.yml

+  using: "composite"
+  steps:


I feel like this is an unnecessary over reach on this PR. Just leave it in the Dockerfile and make your changes in the entrypoint.sh.

mikesigs

I am not the owner of this repo, but I am interested in your PR so I gave it a review.

mikesigs · 2023-03-02T18:46:32Z

@micnncim This would be a nice addition.

vlavrynovych

Don't replace owner's info like action name, desc, author
Fix description of the force parameter
Add examples for the new parameters

vlavrynovych · 2023-11-12T07:51:25Z

README.md

@@ -34,13 +37,13 @@ jobs:
      - uses: actions-ecosystem/action-get-latest-tag@v1
        id: get-latest-tag

-      - uses: actions-ecosystem/action-bump-semver@v1
+      - uses: thejeff77/action-bump-semver@v1.0.0


+1 about use of actions-ecosystem
If you do a PR to original repo it should stay as is. In your own repo feel free to override it.

vlavrynovych · 2023-11-12T07:52:57Z

README.md

        id: bump-semver
        with:
          current_version: ${{ steps.get-latest-tag.outputs.tag }}
          level: minor

-      - uses: actions-ecosystem/action-push-tag@v1
+      - uses: thejeff77/action-push-tag@v1.0.0


Same here. +1 about use of actions-ecosystem

vlavrynovych · 2023-11-12T07:55:03Z

README.md

+| `tag`        | A Git tag name.                        | `string` | `true`   | `N/A`   |
+| `message`    | A message for the Git tag.             | `string` | `false`  | `''`    |
+| `ref`        | Commit SHA or tag to target.           | `string` | `false`  | `''`    |
+| `force`      | A message for the Git tag.             | `boolean`| `false`  | `false` |


Please fix desciption of the force paramater

vlavrynovych · 2023-11-12T07:57:13Z

README.md

+| ------------ | -------------------------------------- | -------- | -------- | ------- |
+| `tag`        | A Git tag name.                        | `string` | `true`   | `N/A`   |
+| `message`    | A message for the Git tag.             | `string` | `false`  | `''`    |
+| `ref`        | Commit SHA or tag to target.           | `string` | `false`  | `''`    |


It will be nice to update example in the README.MD with an real case where you use all the new parameters.
For example: it's not clear if the force parameter is analog of git force or it's something else. And why would I need a ref

vlavrynovych · 2023-11-12T07:57:49Z

action.yml

+name: Push Any Git Tag
+description: based on Actions Ecosystem Push Tag - Fixed with additional features.
+author: Actions Ecosystem & theJeff77


vlavrynovych · 2023-11-12T08:02:27Z

action.yml

+    type: string
+    required: false
+  force:
+    description: Whether or not to force push (overwrite) the tag if it already exists. Useful for walking tags.


This descriptions are not available for me when I read the docs or trying to see it will work for me

thejeff77 and others added 2 commits January 12, 2023 10:46

adding inputs for force and ref

d660e47

Add new options to README

7e7e3ce

github-actions bot added the size/M label Jan 12, 2023

thejeff77 and others added 12 commits January 12, 2023 10:52

Update action.yml

aa10244

Update action.yml

af134af

Update action.yml

f6ff252

remove runs-on param

Update action.yml

e784ba8

Update action.yml

adab31b

Update README.md

b6bf63c

removing dockerfile and entrypoint

9a33dfe

adding gitignore file

2c8d36f

Update action.yml

f110b45

Update README.md

c3b8c44

Update README.md

4215f06

Update README.md

31cbb32

mikesigs reviewed Mar 2, 2023

View reviewed changes

vlavrynovych suggested changes Nov 12, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow overwrite and ref targets. Adds more functionality / flexibility to action #14

Allow overwrite and ref targets. Adds more functionality / flexibility to action #14

thejeff77 commented Jan 12, 2023

mikesigs Mar 2, 2023

vlavrynovych Nov 12, 2023

mikesigs Mar 2, 2023

mikesigs Mar 2, 2023

vlavrynovych Nov 12, 2023

mikesigs Mar 2, 2023

vlavrynovych Nov 12, 2023

mikesigs Mar 2, 2023

vlavrynovych Nov 12, 2023

mikesigs Mar 2, 2023

mikesigs left a comment

mikesigs commented Mar 2, 2023

vlavrynovych left a comment

vlavrynovych Nov 12, 2023

vlavrynovych Nov 12, 2023

vlavrynovych Nov 12, 2023

vlavrynovych Nov 12, 2023

vlavrynovych Nov 12, 2023

vlavrynovych Nov 12, 2023

Allow overwrite and ref targets. Adds more functionality / flexibility to action #14

Are you sure you want to change the base?

Allow overwrite and ref targets. Adds more functionality / flexibility to action #14

Conversation

thejeff77 commented Jan 12, 2023

What this PR does / Why we need it

Which issue(s) this PR fixes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikesigs left a comment

Choose a reason for hiding this comment

mikesigs commented Mar 2, 2023

vlavrynovych left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment