Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for a list of channels to be passed in #334

Open
Skarlso opened this issue Apr 1, 2022 · 1 comment · May be fixed by #335
Open

Allow for a list of channels to be passed in #334

Skarlso opened this issue Apr 1, 2022 · 1 comment · May be fixed by #335
Labels
enhancement New feature or request

Comments

@Skarlso
Copy link

Skarlso commented Apr 1, 2022

What you want to add

      - name: slack on failure
        if: failure()
        uses: actions-ecosystem/action-slack-notifier@fc778468d09c43a6f4d1b8cccaca59766656996a
        with:
          slack_token: <token>
          message: "${{ inputs.name }} has failed"
          channel: channel1, channel2, channel3
          color: red
          verbose: true

Why this is needed

Because instead of duplicating the action three times, this is a much nicer approach. And it would be relatively easy to implement. Just check if channel contains , then do a loop and send it to all channels.
@Skarlso Skarlso added the enhancement New feature or request label Apr 1, 2022
@Skarlso Skarlso mentioned this issue Apr 1, 2022
Closed
@Skarlso
Copy link
Author

Skarlso commented Apr 1, 2022

Alternatively, introduce a new parameter called channels so it doesn't break anything and remains backwards compatible.

@Skarlso Skarlso linked a pull request Apr 1, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add optional coma separated channel list Skarlso/action-slack-notifier
1 participant
@Skarlso