enhancement: Add option to specify rust-toolchain.toml path #69
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbb
requested changes
Aug 27, 2025
There was a problem hiding this comment.
The rust-cache action also needs to be configured if the Rust source is not in the root of the repository: Swatinem/rust-cache#153 or Swatinem/rust-cache#223.
As I understand it the workspaces value needs to be configured. Potentially you can just set it to the same value as rust_toolchain_dir.
If the cache-workspaces input is not set then it should autoconfigure based on rust_toolchain_dir. If cache-workspaces is explicitly provided, it must always take precedence.
Since the configuration now is for the Rust sources directory, not just the toolchain path, a better name might be something like "rust-src-dir" or "rust-base-dir".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #47